Fix crowdin update script #9969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9969 +/- ##
==========================================
+ Coverage 42.23% 42.27% +0.03%
==========================================
Files 610 610
Lines 80295 80364 +69
==========================================
+ Hits 33915 33971 +56
+ Misses 42217 42213 -4
- Partials 4163 4180 +17
Continue to review full report at Codecov.
|
Member
Author
|
Given that some translations are enclosed between quotes and some not, I've decided for a more strict pattern matching to avoid changing lines we're not supposed to. In the attachment you can see files before and after processing them with the script. |
bagasme
reviewed
Jan 25, 2020
zeripath
approved these changes
Jan 25, 2020
lunny
approved these changes
Jan 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. Works fine in my environment.