Issue search support elasticsearch #9428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9428 +/- ##
==========================================
+ Coverage 42.36% 43.67% +1.31%
==========================================
Files 619 577 -42
Lines 81003 79869 -1134
==========================================
+ Hits 34313 34885 +572
+ Misses 42482 40676 -1806
- Partials 4208 4308 +100
Continue to review full report at Codecov.
|
lafriks
reviewed
Dec 19, 2019
lafriks
reviewed
Dec 19, 2019
lafriks
reviewed
Dec 19, 2019
09b7458 to
c23ffc6
Compare
guillep2k
reviewed
Dec 20, 2019
c23ffc6 to
580e2cb
Compare
Member
Author
|
Partilly fix #6648 |
6543
reviewed
Dec 25, 2019
Member
|
I think your rebase broke something ... |
565f0ea to
d31ba64
Compare
Member
Author
|
@6543 fixed. :) |
d31ba64 to
51a65a2
Compare
guillep2k
reviewed
Feb 11, 2020
Member
There was a problem hiding this comment.
Is this compatible with int64?
Member
There was a problem hiding this comment.
Is this intended to be a string, or just []interface{}?
Member
Author
There was a problem hiding this comment.
Because NewTermsQuery needs a slice of interface as parameters.
modules/indexer/issues/indexer.go
Outdated
Member
There was a problem hiding this comment.
This messes up with our paging, but I don't see much way around it.
Member
Author
There was a problem hiding this comment.
Yes. I left it for future PR.
guillep2k
approved these changes
Feb 11, 2020
6543
approved these changes
Feb 11, 2020
d965f11 to
e41403b
Compare
Member
Author
|
make L-G-T-M work. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #6150
This PR introduce a new issue indexer type - elasticsearch.
It will connect to an elasticsearch server or cluster to store issue indexer and search by keyword.
This will have better performance than
dborbleveon a bigger gitea instance.Especially there are serval gitea instances to share indexer.
This PR also added a test for elastic search issue indexer.