Skip to content

Admin config page mailertype setting option update #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 5 commits into from
Feb 6, 2019
Merged

Admin config page mailertype setting option update #5973

techknowlogick merged 5 commits into from
Feb 6, 2019

Conversation

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Feb 6, 2019

Fix #5972

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 6, 2019
@codecov-io
Copy link

codecov-io commented Feb 6, 2019 •
edited
Loading

Codecov Report

Merging #5973 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5973      +/-   ##
==========================================
+ Coverage    38.7%   38.71%   +<.01%     
==========================================
  Files         330      330              
  Lines       48697    48697              
==========================================
+ Hits        18849    18853       +4     
+ Misses      27119    27114       -5     
- Partials     2729     2730       +1
Impacted Files Coverage Δ
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
routers/repo/view.go 47.3% <0%> (+1.19%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c721fe...34ca473. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2019
zeripath
zeripath approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2019
lafriks
lafriks reviewed Feb 6, 2019
View reviewed changes
@techknowlogick techknowlogick merged commit ad059fd into go-gitea:master Feb 6, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-13 branch February 6, 2019 16:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks left review comments

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

can't evaluate field UseSendmail in type interface

6 participants

@techknowlogick @codecov-io @lunny @lafriks @zeripath @GiteaBot