Skip to content

Conversation

@zeripath
Copy link
Contributor

@zeripath zeripath commented May 7, 2020

Backport #11305

  • Manage port in submodule refurl

Fix #11304

Signed-off-by: Andrew Thornton [email protected]

  • fix lint

Signed-off-by: Andrew Thornton [email protected]

  • URLJoin is causes a cyclic dependency and possibly isn't what what we want anyway

Signed-off-by: Andrew Thornton [email protected]

  • Protect against leading .. in scp syntax

Signed-off-by: Andrew Thornton [email protected]

Co-authored-by: Lauris BH [email protected]

* Manage port in submodule refurl

Fix go-gitea#11304

Signed-off-by: Andrew Thornton <[email protected]>

* fix lint

Signed-off-by: Andrew Thornton <[email protected]>

* URLJoin is causes a cyclic dependency and possibly isn't what what we want anyway

Signed-off-by: Andrew Thornton <[email protected]>

* Protect against leading .. in scp syntax

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
@zeripath zeripath added this to the 1.11.5 milestone May 7, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2020
@jolheiser jolheiser merged commit 19626b9 into go-gitea:release/v1.11 May 7, 2020
@zeripath zeripath deleted the backport-11305 branch May 7, 2020 15:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants