Skip to content

Ensure only own addresses are updated #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guillep2k merged 2 commits into from
Feb 21, 2020
Merged

Ensure only own addresses are updated #10397

guillep2k merged 2 commits into from
Feb 21, 2020

Conversation

@guillep2k
Copy link
Member

@guillep2k guillep2k commented Feb 21, 2020

As title

@guillep2k guillep2k added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.11 labels Feb 21, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone Feb 21, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 21, 2020
@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

Merging #10397 into master will decrease coverage by <.01%.
The diff coverage is 67.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10397      +/-   ##
==========================================
- Coverage   43.73%   43.73%   -0.01%     
==========================================
  Files         586      586              
  Lines       81113    81113              
==========================================
- Hits        35476    35473       -3     
- Misses      41248    41249       +1     
- Partials     4389     4391       +2
Impacted Files Coverage Δ
modules/indexer/code/indexer.go 42.62% <ø> (ø) ⬆️
models/issue.go 53.82% <0%> (ø) ⬆️
routers/home.go 46.8% <0%> (ø) ⬆️
models/repo.go 51.32% <0%> (ø) ⬆️
modules/setting/indexer.go 91.89% <100%> (ø) ⬆️
routers/repo/search.go 65.62% <100%> (ø) ⬆️
modules/git/repo_language_stats.go 66.17% <100%> (ø) ⬆️
modules/indexer/code/wrapped.go 40.74% <66.66%> (ø) ⬆️
modules/indexer/code/bleve.go 64.7% <68.83%> (ø) ⬆️
modules/indexer/code/search.go 80.45% <70%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e27b32e...bbb5ddb. Read the comment docs.

@guillep2k guillep2k merged commit cfcd8e4 into go-gitea:master Feb 21, 2020
guillep2k added a commit to guillep2k/gitea that referenced this pull request Feb 21, 2020
@guillep2k
Ensure only own addresses are updated (go-gitea#10397)
2a073e5
@guillep2k guillep2k mentioned this pull request Feb 21, 2020
Merged
@guillep2k guillep2k deleted the fix-email-2 branch February 21, 2020 13:15
guillep2k added a commit that referenced this pull request Feb 21, 2020
@guillep2k
Ensure only own addresses are updated (#10397) (#10399)
3cee15e
@guillep2k guillep2k added the backport/done All backports for this PR have been created label Feb 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@jolheiser jolheiser jolheiser approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@guillep2k @codecov-io @lunny @zeripath @jolheiser @GiteaBot