Skip to content

fix filter label emoji width #10241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sapk merged 2 commits into from
Feb 11, 2020
Merged

fix filter label emoji width #10241

sapk merged 2 commits into from
Feb 11, 2020

Conversation

@jaqra
Copy link
Contributor

@jaqra jaqra commented Feb 11, 2020

Before:
Screenshot_2020-02-11_22-59-22

After:
Screenshot_2020-02-11_23-28-16

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 11, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI type/bug backport/v1.11 labels Feb 11, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 11, 2020
@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #10241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10241   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files         582      582           
  Lines       80048    80048           
=======================================
  Hits        34962    34962           
  Misses      40751    40751           
  Partials     4335     4335

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150393b...3a46c5c. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2020
@sapk sapk merged commit 6c823c7 into go-gitea:master Feb 11, 2020
@sapk
Copy link
Member

sapk commented Feb 11, 2020

Please send backport

@jaqra jaqra mentioned this pull request Feb 11, 2020
Merged
sapk pushed a commit that referenced this pull request Feb 11, 2020
fix filter label emoji width (#10241) (#10244)
1cd6233
@sapk sapk added the backport/done All backports for this PR have been created label Feb 11, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jaqra @codecov-io @sapk @lafriks @GiteaBot @metiftikci