Skip to content

Conversation

@michaelkuhn
Copy link
Contributor

The js-quick-submit class needs to be applied to SimpleMDE's input field, which is currently only done for wiki pages.

Fixes #10937

The js-quick-submit class needs to be applied to SimpleMDE's input
field, which is currently only done for wiki pages.

Fixes go-gitea#10937
@codecov-io
Copy link

Codecov Report

Merging #10986 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10986      +/-   ##
==========================================
- Coverage   43.62%   43.59%   -0.03%     
==========================================
  Files         597      597              
  Lines       83923    83923              
==========================================
- Hits        36610    36589      -21     
- Misses      42803    42822      +19     
- Partials     4510     4512       +2     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 50.00% <0.00%> (-18.75%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/git/repo_language_stats.go 66.17% <0.00%> (-4.42%) ⬇️
models/unit.go 41.97% <0.00%> (-2.47%) ⬇️
modules/log/file.go 75.52% <0.00%> (-2.10%) ⬇️
modules/log/event.go 64.61% <0.00%> (-1.03%) ⬇️
modules/git/repo.go 47.28% <0.00%> (-0.84%) ⬇️
routers/repo/view.go 36.14% <0.00%> (-0.68%) ⬇️
modules/queue/workerpool.go 56.93% <0.00%> (ø)
services/pull/pull.go 35.88% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1648bf2...933ab38. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2020
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected
Thank you for your contribution!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 6, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Apr 6, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit ecb1768 into go-gitea:master Apr 7, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
The js-quick-submit class needs to be applied to SimpleMDE's input
field, which is currently only done for wiki pages.

Fixes go-gitea#10937

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: guillep2k <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submit forms with Ctrl+Enter combination

8 participants