Skip to content

Conversation

@jolheiser
Copy link
Member

Supersedes #10960

Instead, set GO111MODULE=off for xgo and gxz downloads.

@jolheiser jolheiser added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 4, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Apr 4, 2020
Signed-off-by: jolheiser <[email protected]>
@jolheiser
Copy link
Member Author

jolheiser commented Apr 5, 2020

@techknowlogick The error looks like the one we were discussing earlier this week, but I can't remember how/if we "fixed" it.
https://drone.gitea.io/go-gitea/gitea/23303/6/3

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2020
@6543
Copy link
Member

6543 commented Apr 5, 2020

@jolheiser If you find out let me know - need this for tea too ;)

@lunny
Copy link
Member

lunny commented Apr 5, 2020

I ever did that with cd /tmp && go get .... to avoid change the go.mod but with go module.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 6, 2020
release-compress: | $(DIST_DIRS)
@hash gxz > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
$(GO) get -u github.com/ulikunitz/xz/cmd/gxz; \
GO111MODULE=off $(GO) get -u github.com/ulikunitz/xz/cmd/gxz; \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I'm unsure of.
@techknowlogick Thoughts?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 6, 2020
@lunny lunny merged commit 1648bf2 into go-gitea:master Apr 6, 2020
@6543
Copy link
Member

6543 commented Apr 6, 2020

@jolheiser @lunny added this to https://gitea.com/gitea/tea/pulls/115 🎉

@jolheiser jolheiser deleted the xgo-gxz branch September 18, 2020 14:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants