Avoid logging []byte in queue failures - convert to string first #10865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
approved these changes
Mar 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #10865 +/- ##
==========================================
+ Coverage 43.40% 43.41% +0.01%
==========================================
Files 593 593
Lines 83271 83276 +5
==========================================
+ Hits 36140 36154 +14
+ Misses 42640 42636 -4
+ Partials 4491 4486 -5
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Mar 29, 2020
lunny
approved these changes
Mar 29, 2020
Member
|
make L-G-T-M |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst debugging an issue on discord I noticed that we were logging:
because the cfg is possibly being passed as a
[]byteto log/fmt.Errorf. The solution is to check if the config is a[]byteand if so cast it to a string before logging.Signed-off-by: Andrew Thornton [email protected]