Move JS build dependencies to 'dependencies' #10763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move all JS build dependencies to 'dependencies' - update all JS dependencies Reason for this is that npm will only install 'dependencies' when under the effect of NODE_ENV=production which may be present on some build systems. Linters currently need to be depdendencies because we run linting as part of the build step, but I plan to move them to a separate 'lint' target which means they can move to devDependencies then. Fixes: go-gitea#10761
zeripath
approved these changes
Mar 18, 2020
techknowlogick
approved these changes
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move JS build dependencies to 'dependencies'
Reason for this is that npm will only install 'dependencies' when under the effect of NODE_ENV=production which may be present on some build systems.
Linters currently need to be dependencies because we run linting as part of the build step, but I plan to move them to a separate 'lint' target which means they can move to devDependencies then.
Fixes: #10761