ui: hide gear icon for user who can't use them on sidebar #10750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: If user can't choose the Assignees labels and Milestone It's not usefull to show a gear label , and it It will mislead the user into thinking that it's a BUG rather than thy don't have permission to chosse them. Signed-off-by: a1012112796 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10750 +/- ##
==========================================
- Coverage 43.54% 43.53% -0.01%
==========================================
Files 589 589
Lines 82662 82662
==========================================
- Hits 35992 35990 -2
Misses 42198 42198
- Partials 4472 4474 +2
Continue to review full report at Codecov.
|
zeripath
approved these changes
Mar 17, 2020
lunny
approved these changes
Mar 17, 2020
Member
Author
|
suggest add this change on V1.11. @techknowlogick @lunny |
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Mar 27, 2020
In gitea now seting, only users have write permission can add Assignees, but if a user who don't have write permission also can add Assignees when they creat a Pull Request from a forked repo ,Because It haven't check the permission, so it's a bug. This PR should fix this bug by add a check for write permission. two other small changes: * hide gear on new PR page when it's not necessary like go-gitea#10750, * remove some unusefull comments. Signed-off-by: a1012112796 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason:
If user can't choose the Assignees labels and Milestone It's
not usefull to show a gear label , and it It will mislead the
user into thinking that it's a BUG rather than thy don't have
permission to chosse them.