Skip to content

Fix redirection path if Slack webhook channel is invalid (#10548) #10566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lafriks merged 1 commit into from
Mar 2, 2020
Merged

Fix redirection path if Slack webhook channel is invalid (#10548) #10566

lafriks merged 1 commit into from
Mar 2, 2020

Conversation

@jamesorlakin
Copy link
Contributor

@jamesorlakin jamesorlakin commented Mar 2, 2020

A backport of #10548, potentially pointing at the right branch this time! 😃

@jamesorlakin
Fix redirection path if Slack webhook channel is invalid
cab0cac 
The path to the hook config is already defined by orgRepoCtx
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 2, 2020
@lafriks lafriks added this to the 1.11.2 milestone Mar 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2020
@lafriks lafriks merged commit 65dceb6 into go-gitea:release/v1.11 Mar 2, 2020
@zeripath zeripath changed the title [Backport] Bugfix/slack webhook redirect backport Fix redirection path if Slack webhook channel is invalid (#10548) Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.11.2

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesorlakin @lafriks @guillep2k @GiteaBot