Skip to content

Fix double PR notification from API #10482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jolheiser merged 2 commits into from
Feb 26, 2020
Merged

Fix double PR notification from API #10482

jolheiser merged 2 commits into from
Feb 26, 2020

Conversation

@jolheiser
Copy link
Member

@jolheiser jolheiser commented Feb 26, 2020

NotifyNewPullRequest is already called in the service:

gitea/services/pull/pull.go

Line 50 in 084a2b0

notification.NotifyNewPullRequest(pr)

@jolheiser jolheiser added type/bug modifies/api This PR adds API routes or modifies them backport/v1.11 labels Feb 26, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 26, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 26, 2020
@codecov-io
Copy link

codecov-io commented Feb 26, 2020 •
edited
Loading

Codecov Report

Merging #10482 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10482      +/-   ##
==========================================
- Coverage   43.72%    43.7%   -0.02%     
==========================================
  Files         586      586              
  Lines       81408    81408              
==========================================
- Hits        35592    35576      -16     
- Misses      41407    41425      +18     
+ Partials     4409     4407       -2
Impacted Files Coverage Δ
routers/routes/routes.go 86.27% <100%> (ø) ⬆️
models/repo_mirror.go 2.12% <0%> (-10.64%) ⬇️
services/pull/check.go 50% <0%> (-6.71%) ⬇️
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-2.57%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
services/mirror/mirror.go 18.75% <0%> (-0.66%) ⬇️
modules/git/repo.go 47.7% <0%> (+0.91%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a1060b...71bb0e6. Read the comment docs.

@jolheiser jolheiser merged commit 78585b1 into go-gitea:master Feb 26, 2020
@jolheiser jolheiser deleted the double-pr-api branch February 26, 2020 18:12
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 26, 2020
@jolheiser
Fix double PR notification from API (go-gitea#10482)
a8c3389 
Signed-off-by: jolheiser <[email protected]>
@jolheiser jolheiser mentioned this pull request Feb 26, 2020
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 26, 2020
lafriks pushed a commit that referenced this pull request Feb 26, 2020
@jolheiser
Fix double PR notification from API (#10482) (#10486)
1fbdd93 
Signed-off-by: jolheiser <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jolheiser @codecov-io @techknowlogick @6543 @GiteaBot