Skip to content

[API] enable paggination for ListRepoTags #10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 8 commits into from
Feb 25, 2020
Merged

[API] enable paggination for ListRepoTags #10454

techknowlogick merged 8 commits into from
Feb 25, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Feb 25, 2020

close #10453

6543
6543 commented Feb 25, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 25, 2020
6543
6543 commented Feb 25, 2020
View reviewed changes
@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 25, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 25, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 25, 2020
lafriks
lafriks reviewed Feb 25, 2020
View reviewed changes
guillep2k
guillep2k approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits. Maximum page size is actually setting.API.MaxResponseItems which defaults to 50.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@techknowlogick
Copy link
Member

techknowlogick commented Feb 25, 2020

please "update branch"

@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #10454 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10454      +/-   ##
==========================================
+ Coverage   43.68%    43.7%   +0.02%     
==========================================
  Files         586      586              
  Lines       81411    81411              
==========================================
+ Hits        35561    35582      +21     
+ Misses      41446    41428      -18     
+ Partials     4404     4401       -3
Impacted Files Coverage Δ
modules/git/command.go 86.95% <0%> (-2.61%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0%> (-1.93%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
services/pull/check.go 53.65% <0%> (+0.6%) ⬆️
services/pull/pull.go 36.07% <0%> (+0.87%) ⬆️
models/notification.go 65.18% <0%> (+1.05%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
services/pull/patch.go 62.89% <0%> (+2.51%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4a982...25e5837. Read the comment docs.

@6543
Copy link
Member Author

6543 commented Feb 25, 2020

@techknowlogick done ;)

@techknowlogick techknowlogick merged commit 4427a93 into go-gitea:master Feb 25, 2020
@6543 6543 deleted the api_pagginate-repoListTags branch February 25, 2020 19:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

API for List a repository's tags

6 participants

@6543 @techknowlogick @codecov-io @lafriks @guillep2k @GiteaBot