Skip to content

all: go modules, drop vendor #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2018
Merged

all: go modules, drop vendor #600

merged 2 commits into from
Sep 1, 2018

Conversation

cristaloleg
Copy link
Member

Fixes #599 #598

@cristaloleg cristaloleg added bug Something isn't working enhancement New feature or request labels Sep 1, 2018
@cristaloleg cristaloleg self-assigned this Sep 1, 2018
@coveralls
Copy link

coveralls commented Sep 1, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.395% when pulling 5688b5f on go-modules into b6241d8 on master.

quasilyte
quasilyte approved these changes Sep 1, 2018
View reviewed changes
Copy link
Member

@quasilyte quasilyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, thanks!
LGTM.

@cristaloleg cristaloleg merged commit 522a470 into master Sep 1, 2018
@cristaloleg cristaloleg deleted the go-modules branch September 1, 2018 14:03
@cristaloleg cristaloleg mentioned this pull request Sep 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quasilyte quasilyte quasilyte approved these changes

Assignees

@cristaloleg cristaloleg

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cristaloleg @coveralls @quasilyte