Only recreate table model when Data layer changes #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt order in _update_visible.
74a065f to
2ade3ea
Compare
Member
Author
|
Rebased to get CI fixes |
Member
|
@Carifio24 - do you think it would be easy to add a test for this, or would it be non-trivial? |
Member
Author
|
@astrofrog I think it should actually be pretty straightforward. I'll try adding one and see if that is indeed the case. |
Member
Author
|
@astrofrog I just added a test - it creates a new subset and checks that the table model and the row ordering are preserved afterwards. |
astrofrog
approved these changes
Mar 22, 2023
Member
astrofrog
left a comment
There was a problem hiding this comment.
Looks good to me provided the CI passes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a change(/bugfix?) requested by @aagoodman. Currently, after a user makes a selection to create a new subset after having sorted the table, the sorting is undone once the subset is created. This leads to a not-great UX - if one is trying to create multiple selections based on a column's values, having to re-sort each time is annoying.
The reason for this is that the table model is recreated any time the layers change, which resets any sorting. This PR modifies the layer changed callback to only recreate the table model if the actual
Datalayer has changed - otherwise, we just call the model's_update_visible. This also necessitates making the masks in_update_visibleaware of the current order.