Skip to content

Conversation

@bcomnes
Copy link
Collaborator

@bcomnes bcomnes commented Sep 12, 2021

This fixes swr testing.

Closes #844

# Conflicts:
#	importSwr.test.js
#	package.json
@bcomnes bcomnes requested a review from Schwartz10 September 12, 2021 19:44
@bcomnes bcomnes self-assigned this Sep 12, 2021
@bcomnes
Copy link
Collaborator Author

bcomnes commented Sep 12, 2021

Don't have time to check out why these are failing now, but fundamentally export const flushPromises = () => new Promise(setImmediate) no longer just works, and then all of the async assumption start seem to fail when you replace it with setTimeout(0).

@Schwartz10
Copy link
Contributor

Findings so far:

so basically cbbf292 this fails

this tests /components/Wallet/Message directory, which has 2 test files in it: index.test.js and /Detail/index.test.js

if i run those test files individually on github action, they both pass

if i run them via npm run test /components/Wallet/Message - everything passes, but the non zero exit code appears

@Schwartz10 Schwartz10 merged commit e0b1fd8 into primary Sep 14, 2021
@Schwartz10 Schwartz10 deleted the update-jest-stuff branch September 14, 2021 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants