Skip to content

Conversation

@Schwartz10
Copy link
Contributor

No description provided.

erchaves and others added 30 commits September 3, 2021 18:27
Updating the readme to explain how `npm link` is used for local
development.
Note that this is currently using both urls and view changes in a hacky
way. We should probably decide which pattern to use and switch to just
that pattern.
and use router instead of window.location — even though this is just
temp logic and will go away
Should be a trivial merge later
# Conflicts:
#	components/Msig/Home/index.jsx
Swapping out childView for detectPage. Consider using next.js’s files
to set the page instead. But this works fine.
…he functionality

It’s weird that this just started breaking because looking at all the
relevant files, none of them have been changed recently. So I'm not
sure when or how this breaking change happened. This probably isn't the
correct fix. So we probably want to figure out how to not have
target=‘_blank’ as a default.
@Schwartz10 Schwartz10 marked this pull request as ready for review September 20, 2021 21:25
@Schwartz10 Schwartz10 merged commit e636f53 into primary Sep 20, 2021
@Schwartz10 Schwartz10 deleted the GLIF-39 branch September 20, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants