-
Notifications
You must be signed in to change notification settings - Fork 32
Glif 39 #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Glif 39 #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the readme to explain how `npm link` is used for local development.
Note that this is currently using both urls and view changes in a hacky way. We should probably decide which pattern to use and switch to just that pattern.
and use router instead of window.location — even though this is just temp logic and will go away
Should be a trivial merge later
# Conflicts: # components/Msig/Home/index.jsx
Swapping out childView for detectPage. Consider using next.js’s files to set the page instead. But this works fine.
… into it's own component
…he functionality It’s weird that this just started breaking because looking at all the relevant files, none of them have been changed recently. So I'm not sure when or how this breaking change happened. This probably isn't the correct fix. So we probably want to figure out how to not have target=‘_blank’ as a default.
Remove and change signer not yet working
Cleanup Add/Rm signer UI
Refactor navigate func
Add tests for Msig/AddRmSigners
Make Change Signer its own page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.