Feat/button maxheight #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to relative to avoid overlap on small viewports. Remove explicit width declarations
Schwartz10
requested changes
Oct 13, 2020
Contributor
Schwartz10
left a comment
There was a problem hiding this comment.
Hey @as-dr this all seems fine to me, i haven't looked in the UI myself yet. but let's make the same styling changes to the msig change owner and withdraw flow here, so we don't forget
Contributor
Author
|
@Schwartz10 Great call, had this in my head but lost it yesterday. This is resolved, now. I've also added ref screenshots for both Withdraw and Send flows showing the height cap on the progress buttons. |
Schwartz10
approved these changes
Oct 13, 2020
Schwartz10
added a commit
that referenced
this pull request
Oct 13, 2020
* c300df4 (HEAD -> dev, origin/dev) Bump glifs * 0f8d872 Fix proptypes * e92ebdb Add tx fee to total in send flow (#678) * cd352e6 Merge branch 'primary' into dev |\ | * 3aa0340 Release v2.1.3 (#665) * 6bcb56f Bump version * a8bdc81 Add tooltip in Logout button (#676) * b9f5ea5 Vault UI Improvements (#673) * 9cdfd10 Better insufficient funds err (#674) * f0a3d6d Remove chaingetmsg calls to fetch params (#675) * 9399618 Feat/button maxheight (#666) * 4ebde76 Feat/add tooltip (#663) * c0e8a9e Update webusb transport (#672) * 2ee22ea Improve AccountSummary (#668) * de3afff Bump glifs (#671) * 0c6abc0 Bump version * dac03cc Simplify and improve node connection test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ButtonClosefromfixedtorelativeposition to avoid overlap issueswidthdeclarationspaddingofFundsinput to matchNumbersinputminWidthdeclaration inNumbersinput that was affecting its styling at smaller viewportsWithdrawflow stylingChangeOwnerflow styling to matchSendandWithdrawflowsWarningcard stylingReference
Send Flow
Height capped
Withdraw Flow
Showing we cap the height
Warning Card
(Mini step towards restyling these)
