Skip to content

Wayland: Ignore key repeat events when no window has keyboard focus #2732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dougbinks merged 2 commits into from
Jul 5, 2025
Merged

Wayland: Ignore key repeat events when no window has keyboard focus #2732

dougbinks merged 2 commits into from
Jul 5, 2025

Conversation

@GamesTrap
Copy link
Contributor

@GamesTrap GamesTrap commented Jun 26, 2025

@GamesTrap GamesTrap requested a review from elmindreda as a code owner June 26, 2025 17:43
@GamesTrap GamesTrap mentioned this pull request Jun 26, 2025
Closed
@GamesTrap
Copy link
Contributor Author

GamesTrap commented Jun 26, 2025 •
edited
Loading

Seems like MSVC is unhappy about deps/nuklear.h :(

D:\a\glfw\glfw\deps\nuklear.h(3433,37): error C2220: the following warning is treated as an error [D:\a\glfw\glfw\build-win32-shared-x86\tests\inputlag.vcxproj]

(compiling source file '../../tests/inputlag.c')

Upstream issue: Immediate-Mode-UI/Nuklear#751

@dougbinks dougbinks self-requested a review June 28, 2025 11:01
@dougbinks dougbinks self-assigned this Jun 28, 2025
@dougbinks dougbinks added bug Bug reports and bugfix pull requests Wayland input Keyboard, joystick or mouse labels Jun 28, 2025
@dougbinks
Copy link
Contributor

dougbinks commented Jul 5, 2025 •
edited
Loading

Thanks for this.

You asked about whether event = GLFW_TRUE; should be set outside the test for _glfw.wl.keyboardFocus, I believe not though the behaviour of event waiting is not currently consistent across platforms.

Checklist for bug fixes:

  • Change log entry in README.md, describing the incorrect behavior DONE
  • Credits entries in CONTRIBUTORS.md for all authors of the bug fix DONE, you are in the credits already as Jan Schuerkamp but we can change it to Jan Schürkamp if you like since it's UTF-8 encoded.

I'll make a local fix for nuklear.h and then merge this PR. If you want your name changed to include the accent let me know (if it's after the merge I can make the change in a separate commit).

@GamesTrap
Copy link
Contributor Author

GamesTrap commented Jul 5, 2025

If you want your name changed to include the accent let me know (if it's after the merge I can make the change in a separate commit).

I've changed it now :)

@dougbinks dougbinks merged commit 506c11b into glfw:master Jul 5, 2025
3 of 4 checks passed
@dougbinks
Copy link
Contributor

dougbinks commented Jul 5, 2025

Merged, many thanks for the PR!

@elmindreda elmindreda added this to the 3.4.1 milestone Jul 7, 2025
@Fox2Code Fox2Code mentioned this pull request Jul 7, 2025
Closed
@dougbinks dougbinks mentioned this pull request Jul 8, 2025
Closed
@dougbinks dougbinks mentioned this pull request Jul 16, 2025
Closed
dougbinks added a commit to dougbinks/glfw that referenced this pull request Jul 16, 2025
@dougbinks
Wayland: Reset key repeat timer on window destruction
9364017 
Windows with keyboard focus may have an active key repeat timer.
This should be reset when the window is closed, or key repeat events
could be sent to a NULL window were it not for the quickfix in PR glfw#2732.

Fixes glfw#2741
Probably the source of glfw#2727
@dougbinks dougbinks mentioned this pull request Jul 16, 2025
Merged
dougbinks added a commit that referenced this pull request Jul 17, 2025
@dougbinks
Wayland: Reset key repeat timer on window destruction
feb2a6b 
Windows with keyboard focus may have an active key repeat timer.
This should be reset when the window is closed, or key repeat events
could be sent to a NULL window were it not for the quickfix in PR #2732.

Fixes #2741
Probably the source of #2727
0x484558 pushed a commit to 0x484558/glfw-mc that referenced this pull request Dec 7, 2025
@GamesTrap @0x484558
Wayland: Ignore key repeat events when no window has keyboard focus (g…
99f0989 
…lfw#2732)

* Wayland: Ignore key repeat events when no window has keyboard focus
0x484558 pushed a commit to 0x484558/glfw-mc that referenced this pull request Dec 7, 2025
@dougbinks @0x484558
Wayland: Reset key repeat timer on window destruction
fe85d4f 
Windows with keyboard focus may have an active key repeat timer.
This should be reset when the window is closed, or key repeat events
could be sent to a NULL window were it not for the quickfix in PR glfw#2732.

Fixes glfw#2741
Probably the source of glfw#2727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmindreda elmindreda Awaiting requested review from elmindreda elmindreda is a code owner

@dougbinks dougbinks Awaiting requested review from dougbinks

Assignees

@dougbinks dougbinks

Labels

bug Bug reports and bugfix pull requests input Keyboard, joystick or mouse Wayland

Projects

None yet

Milestone

3.4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@GamesTrap @dougbinks @elmindreda