Skip to content

Conversation

@Fusion
Copy link
Collaborator

@Fusion Fusion commented Oct 2, 2023

This release focuses on fixing compatibility with MySQL8 and groups now being a reserved keyword, without breaking compatibility with other database engines.
This is also the first release using release-please

2.3.0 (2023-10-02)

⚠ BREAKING CHANGES

  • plugins: Rename the groups table to ldapgroups (#326)

Features

  • Update migration code to support table names (#339) (349431c)

Bug Fixes

  • plugins: Rename the groups table to ldapgroups (#326) (675b236)

Miscellaneous Chores


This PR was generated with Release Please. See documentation.

@ghost
Copy link

ghost commented Oct 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Fusion Fusion force-pushed the release-please--branches--dev--components--GLAuth branch from c229bb0 to be47285 Compare October 2, 2023 04:30
@Fusion Fusion force-pushed the release-please--branches--dev--components--GLAuth branch from be47285 to 4449145 Compare October 2, 2023 05:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Fusion Fusion merged commit aa0414f into dev Oct 2, 2023
@Fusion
Copy link
Collaborator Author

Fusion commented Oct 2, 2023

🤖 Release is at https://github.com/glauth/glauth/releases/tag/v2.3.0 🌻

Fusion added a commit that referenced this pull request Oct 2, 2023
* build: make build vars optional and passable via env

* build: use . for BUILD_FILES var to allow buildvcs flag

* build: create mkbindir, build and sha256 targets

* build: reuse build target for each platform specific compilation

* Ensure same go version for main and plugins

* chore: release 2.3.0

Release-As: 2.3.0

* release-please

* Fix(plugins)!: Rename the groups table to ldapgroups (#326)

The groups table name is a reserved keyword in mysql and requires that
the table name be escaped with backticks in order to use the groups
name. Other databases such as postgres do not support the use of the
backticks in the query statements. This change renames the groups table
to ldapgroups in oder to avoid this problem altogether.

This does have a dependency on the backend sql plugins to alter the
schema to match the new name.

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: Chris F Ravenscroft <[email protected]>

* chore: update docker sqlite with ldapgroups (#338)

* feat: Update migration code to support table names (#339)

* chore(dev): release 2.3.0 (#337)

---------

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: shipperizer <[email protected]>
Co-authored-by: Billy Olsen <[email protected]>
Fusion added a commit that referenced this pull request Oct 7, 2023
* build: make build vars optional and passable via env

* build: use . for BUILD_FILES var to allow buildvcs flag

* build: create mkbindir, build and sha256 targets

* build: reuse build target for each platform specific compilation

* Ensure same go version for main and plugins

* chore: release 2.3.0

Release-As: 2.3.0

* release-please

* Fix(plugins)!: Rename the groups table to ldapgroups (#326)

The groups table name is a reserved keyword in mysql and requires that
the table name be escaped with backticks in order to use the groups
name. Other databases such as postgres do not support the use of the
backticks in the query statements. This change renames the groups table
to ldapgroups in oder to avoid this problem altogether.

This does have a dependency on the backend sql plugins to alter the
schema to match the new name.

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: Chris F Ravenscroft <[email protected]>

* chore: update docker sqlite with ldapgroups (#338)

* feat: Update migration code to support table names (#339)

* chore(dev): release 2.3.0 (#337)

* ci: change pr name pattern for release please

* ci: switch to use master as default branch and plan to drop dev

* fix: exploit release-please for tagging in code

* fix: use runtime/debug to fetch git build info

* fix: use newer function to fetch git info for version

* build: drop build tags

---------

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: shipperizer <[email protected]>
Co-authored-by: Billy Olsen <[email protected]>
Fusion added a commit that referenced this pull request Oct 8, 2023
* build: make build vars optional and passable via env

* build: use . for BUILD_FILES var to allow buildvcs flag

* build: create mkbindir, build and sha256 targets

* build: reuse build target for each platform specific compilation

* Ensure same go version for main and plugins

* chore: release 2.3.0

Release-As: 2.3.0

* release-please

* Fix(plugins)!: Rename the groups table to ldapgroups (#326)

The groups table name is a reserved keyword in mysql and requires that
the table name be escaped with backticks in order to use the groups
name. Other databases such as postgres do not support the use of the
backticks in the query statements. This change renames the groups table
to ldapgroups in oder to avoid this problem altogether.

This does have a dependency on the backend sql plugins to alter the
schema to match the new name.

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: Chris F Ravenscroft <[email protected]>

* chore: update docker sqlite with ldapgroups (#338)

* feat: Update migration code to support table names (#339)

* chore(dev): release 2.3.0 (#337)

* ci: change pr name pattern for release please

* ci: switch to use master as default branch and plan to drop dev

* fix: exploit release-please for tagging in code

* fix: use runtime/debug to fetch git build info

* fix: use newer function to fetch git info for version

* build: drop build tags

* feat: graceful shutdown (#343)

* fix: start servers on separate goroutines

* fix: listen to signals for graceful shutdowns

* fix: exit with 0 in case of programmed termination

---------

Signed-off-by: Billy Olsen <[email protected]>
Co-authored-by: shipperizer <[email protected]>
Co-authored-by: Billy Olsen <[email protected]>
@Fusion Fusion deleted the release-please--branches--dev--components--GLAuth branch October 8, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants