Edit config-fields.go CDN URLs #830
Conversation
Modified simple-icons & mdi to use unpgk if jsdelivr is filtered by EasyList.
| */ | ||
| var activeCDN string | ||
|
|
||
| func detectCDN() string { |
There was a problem hiding this comment.
It didn't return an error in my testing, but let me know if it did on your end.
There was a problem hiding this comment.
the function detectCDN() should return an error instead of "None" in case you don't find anything because that's how it should behave according to best practices.
You can read more here:
https://go.dev/doc/tutorial/handle-errors
There was a problem hiding this comment.
Ah, I see what you mean.
I didn’t bother throwing an error since I didn't see it as important, it returns "None" so we don't need to check again if neither CDN is valid.
That said, returning or logging something could definitely help make it clearer to the end-user why icons aren’t showing up. If you or anyone wants to build on that, go for it. This was really just meant as a quick fix.
Updated the Simple Icons and MDI URLs to use unpkg in cases where jsDelivr is blocked by EasyList. There are likely more efficient ways to handle this, but I have very little experience with Go.
I wasn’t able to find an unpkg version for Homarr or Selfhst, may be other alternatives for them. ¯_(ツ)_/¯