-
-
Notifications
You must be signed in to change notification settings - Fork 22
Feat/catalog header support #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the multiple prepare statements error with fallback
This PR adds a `--log-format` parameter to gizmosql_server that allows switching between text (default) and JSON log formats. The JSON format is optimized for ingestion by log aggregation services like Datadog. ## Changes - Added `--log-format` parameter to gizmosql_server CLI with options: text (default), json - Updated all logging statements to output JSON when format is set to "json" - Maintained backward compatibility with default text format - Applied consistent logging across both DuckDB and SQLite backends ## JSON Log Format When using `--log-format json`, all logs are output as single-line JSON objects with: - `level`: Log level (INFO, WARNING, ERROR) - `message`: Human-readable message - Additional context fields like `query`, `component`, `version`, `engine`, etc. ## Example Usage ```bash # Default text format (backward compatible) gizmosql_server --database-filename data.db --print-queries # JSON format for Datadog gizmosql_server --database-filename data.db --print-queries --log-format json ``` ## Testing - Verified both text and JSON formats work correctly - All SQL operations tested and working - Query logging properly outputs in JSON format when enabled - Backward compatibility maintained Addresses issue gizmodata#25 for consistent Arrow logging and provides foundation for structured logging requested by users for Datadog integration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
feat: Add JSON log format support for Datadog integration
- Test workflow can run after CI build or independently - Uses build artifacts when available, falls back to Docker - No duplicate build logic - Flexible setup for different environments
|
ah - I see the logging changes, those are good. Could you pull the latest I don't think we should merge the ECR changes you have in the PR, though (those likely should stay in the fork)... Thanks for the PR! |
|
@prmoore77 #51 is definitely a cleaner approach, I am going to close this PR. Thanks for the quick changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes:
Will work like: