GITC-665: mismatch grants token and cart #9871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84e808b to
3e62f90
Compare
app/assets/v2/js/cart.js
Outdated
|
|
||
| if (!this.selectedETHCartToken) { | ||
| this.selectedETHCartToken = 'DAI'; | ||
| } |
There was a problem hiding this comment.
Thoughts on rewriting this as :
this.selectedETHCartToken =
(grantData.length > 0) && grantData[0].grant_donation_currency ?
grantData[0].grant_donation_currency : 'DAI'
we can remove the loop itself and there shouldn't be any grantData without grant_donation_currency so maybe the grantData[0].grant_donation_currency check is not required as well
…items in the checkout cart for ETH network
3e62f90 to
81fe567
Compare
81fe567 to
c1de8cc
Compare
thelostone-mc
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the same token is used in calculations for the items in the checkout cart for ETH network
Refers/Fixes
GITC-665
Testing
GIVEN I have one ore more items in my cart with 0 matching and another token except DAI selected for checkout
WHEN I add another grant to the cart in the Grants Explorer
THEN I expect to see a single token in the summary (namely the one chosen in the cart)