Skip to content

Conversation

ksolo
Copy link
Contributor

@ksolo ksolo commented Nov 9, 2021

Description

Fix a bug that was causing the load screen to show when the user was scrolling

@ksolo ksolo changed the title Fix/loading icon on inifinite scroll GITC-505 - Fix loading icon on scroll Nov 9, 2021
@ksolo ksolo marked this pull request as ready for review November 9, 2021 17:45
@thelostone-mc
Copy link
Contributor

Could we throw in a video of the fix as well ?

@ksolo ksolo force-pushed the fix/loading-icon-on-inifinite-scroll branch from a01db11 to 73f3515 Compare November 15, 2021 15:58
Copy link

@jeremyschuurmans jeremyschuurmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@gdixon gdixon merged commit b41e19c into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants