Skip to content

Conversation

chibie
Copy link
Contributor

@chibie chibie commented Oct 28, 2021

Description

As a grants contributor using the explorer search and sorting mechanism, I want exact title matches and predictable sort values when using the search bar.

Notes:

Currently, the behaviour of weighted shuffle does not return exact title matches when using the search bar, which is confusing to users.

Update weighted shuffle to ensure that exact title matches are presented first.

Checklist
  • Ensure "Weighted Shuffle" is the default sort option
  • Debounce search input -> perform search after user has stopped typing
  • When a user enters search keyword, sort option should be set to "Most Relevant"
  • When a user clears the search keyword, sort option should revert to "Weighted Shuffle"
  • When a user changes the sort option when a search result is showing, the search result should be sorted accordingly
Refers/Fixes

GITC-406
#9460

Testing

https://share.vidyard.com/watch/9sXqiZJ4Nkr6TAhJbQaJPC?

@chibie chibie marked this pull request as ready for review November 2, 2021 20:55
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @chibie!! I've left a few comments - let me know if you have any questions!

@chibie chibie requested a review from gdixon November 3, 2021 19:26
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants