Skip to content

Conversation

jeremyschuurmans
Copy link

Description

This PR adds unit tests for the Flag model.

Refers/Fixes
Testing

@jeremyschuurmans jeremyschuurmans changed the title Test Flag model WIP: Test Flag model Aug 26, 2021
@jeremyschuurmans jeremyschuurmans marked this pull request as draft August 26, 2021 19:04
@jeremyschuurmans jeremyschuurmans marked this pull request as ready for review August 26, 2021 21:50
@jeremyschuurmans jeremyschuurmans changed the title WIP: Test Flag model Test Flag model Aug 26, 2021
@jeremyschuurmans jeremyschuurmans marked this pull request as draft September 15, 2021 20:45
@jeremyschuurmans jeremyschuurmans changed the title Test Flag model WIP: 7/Test Flag model Sep 15, 2021
@jeremyschuurmans jeremyschuurmans force-pushed the add-grants-unit-tests branch 3 times, most recently from 69bb98a to 81f1318 Compare September 22, 2021 18:35
@jeremyschuurmans jeremyschuurmans changed the title WIP: 7/Test Flag model 7/Test Flag model Sep 22, 2021
@jeremyschuurmans jeremyschuurmans marked this pull request as ready for review September 22, 2021 22:35
@jeremyschuurmans jeremyschuurmans changed the base branch from add-grants-unit-tests to master September 27, 2021 20:27
Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's some merge conflicts that need to be resolved

Jeremy Schuurmans added 8 commits September 29, 2021 07:29
* create new directory for models, copy over Contribution model

* extract grants models to individual files

* rename relocated_models directory, remove original models directory, add imports, resolve circular dependencies

* extract CLRMatch into separate file

* extract Flag into separate file

* extract MatchPledge to separate file

* extract Donation and PhantomFunding

* extract GrantStat into separate file

* refactor

* extract GrantBrandingRoutingPolicy to separate file

* update migration

* add missing import to MatchPledge, remove imports from __init__.py

* add missing import

* decouple GrantCLRCalculation and move to own file

* extract GrantType to own file

* extract GrantCLR to own file

* add missing import

* refactor, add missing imports

* remove whitespace

* resolve circular dependency

* run 'make fix'

* import changes from gitcoinco#9314

* add try/except to migration file instead of editing migration directly

* refactor
@thelostone-mc thelostone-mc merged commit 596f7c0 into gitcoinco:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants