Notifs #6704
Merged
Notifs #6704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## stable #6704 +/- ##
==========================================
- Coverage 27.12% 27.11% -0.02%
==========================================
Files 292 292
Lines 27149 27164 +15
Branches 3990 3994 +4
==========================================
Hits 7365 7365
- Misses 19514 19524 +10
- Partials 270 275 +5
Continue to review full report at Codecov.
|
octavioamu
approved these changes
Jun 4, 2020
danlipert
approved these changes
Jun 8, 2020
Contributor
|
I'm thinking once the bounty is closed is probably best, but either way is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Q: not clear on when the email + GitHub notification + activity should be created for payout flow
Is it each time when funder pays out / when the funder closes the bounty -> just 1 update ?
In other words should these be be in
close_bounty_v1or should it be inpayout_bounty_v1I think it's correct the way it is but wanted to double check
Refers/Fixes
Testing
NOT TESTED