Skip to content

chore: bounty fulfilment changes #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2020
Merged

chore: bounty fulfilment changes #6670

merged 3 commits into from
May 20, 2020

Conversation

@thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented May 18, 2020 •
edited
Loading

Description

  • create migration for removed fields
  • remove un-used fields from UI in bounty submission
Field Description
fulfiller_email converted to a prop as opposed to duplicating info
fulfiller_github_username converted to a prop as opposed to duplicating info
fulfiller_name removed fields
Refers/Fixes

THIS IS SUPPOSED TO GO IN AFTER #6668

Flows Tested
  • Explorer
  • CrossChain Bounty Flow
  • Standard Bounty Flow
  • User Directory
  • Invite Contributors

Total Fulfillments

Screenshot 2020-05-17 at 1 26 16 PM

Fulfillments with fulfiller_name populated

Screenshot 2020-05-17 at 11 37 21 AM

@thelostone-mc thelostone-mc requested a review from androolloyd May 18, 2020 15:23
@thelostone-mc thelostone-mc mentioned this pull request May 18, 2020
Merged
@thelostone-mc thelostone-mc force-pushed the model_v2 branch 5 times, most recently from ab601b7 to b9771f9 Compare May 20, 2020 06:31
@codecov
Copy link

codecov bot commented May 20, 2020 •
edited
Loading

Codecov Report

Merging #6670 into master will increase coverage by 0.01%.
The diff coverage is 61.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6670      +/-   ##
==========================================
+ Coverage   27.11%   27.13%   +0.01%     
==========================================
  Files         291      291              
  Lines       27038    27050      +12     
  Branches     3983     3982       -1     
==========================================
+ Hits         7332     7339       +7     
- Misses      19438    19443       +5     
  Partials      268      268
Impacted Files Coverage Δ
app/app/context.py 0.00% <0.00%> (ø)
app/app/urls.py 86.20% <ø> (ø)
app/dashboard/helpers.py 14.25% <0.00%> (+0.06%) ⬆️
app/dashboard/views.py 11.02% <0.00%> (-0.03%) ⬇️
app/dataviz/d3_views.py 10.10% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.05% <0.00%> (ø)
app/dashboard/models.py 50.45% <96.15%> (+0.03%) ⬆️
app/dashboard/admin.py 58.08% <100.00%> (+0.11%) ⬆️
app/dashboard/router.py 40.89% <100.00%> (+0.40%) ⬆️
app/retail/emails.py 22.45% <100.00%> (+0.03%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2d273...01bd3ef. Read the comment docs.

@thelostone-mc
chore: bounty fulfilment changes
baa68d0 
- remove fields which aren't needed from bounty submission UI
- make fulfiller_email, fulfiller_name into a prop
- remove fulfiller_github_username
- update code references which use the removed db fields
@thelostone-mc
create migrations
b8fb3c9
@thelostone-mc
fix tests
01bd3ef
@danlipert danlipert merged commit cc18786 into gitcoinco:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@androolloyd androolloyd Awaiting requested review from androolloyd

2 more reviewers

@danlipert danlipert danlipert approved these changes

@octavioamu octavioamu octavioamu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thelostone-mc @danlipert @octavioamu