set description and image for SEO #6652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set description and image for SEO (twitter and facebook...)
Codecov Report
@@ Coverage Diff @@
## master #6652 +/- ##
==========================================
+ Coverage 18.32% 27.15% +8.83%
==========================================
Files 282 291 +9
Lines 27455 26961 -494
Branches 4065 3974 -91
==========================================
+ Hits 5031 7322 +2291
+ Misses 22412 19371 -3041
- Partials 12 268 +256
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
May 14, 2020
Contributor
|
@x5engine would you be able to throw in a screenshot please? |
Contributor
Author
|
@thelostone-mc for this one I can't since I didn't get the docker image running on windows :'( help and I'll knock any bugs like flies, mosquitos and so on. |
Contributor
|
@x5engine not sure why you are having issues on windows - maybe try setting up a ubuntu VM? Since you didn't get this running, I'm assuming this is untested? |
Contributor
Author
|
Untested but 90% working |
Contributor
|
locally seems to work ! |
Contributor
Author
|
It works! Would fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set description and image for SEO (twitter and facebook...)
PR fix for #6645