Skip to content

Conversation

@androolloyd
Copy link
Contributor

Description

Tribes Launch v1:

Refers/Fixes
Testing

androolloyd and others added 17 commits May 1, 2020 11:55
…ce/lower serialization weight, if the new view fails, load the old view
… for the majority of the coponents,

better responsive layouts
hide filters on mobile/smaller layouts
…ce/lower serialization weight, if the new view fails, load the old view
… for the majority of the coponents,

better responsive layouts
hide filters on mobile/smaller layouts
Add responsive view for people tab in tribes page
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #6573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6573   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files         288      288           
  Lines       26828    26828           
  Branches     3960     3960           
=======================================
  Hits         7307     7307           
  Misses      19249    19249           
  Partials      272      272           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6e7b75...c6e7b75. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing notes:

  • vue error getting into projects page

  • is missing featured_bounties.css

  • remove quill console logs

  • Bounties popover is not working for me

  • Background is not using any background by default (we use to random them from the image folder)

  • grid on people seems very thin

  • people is loading just gitcoinbot even when Im with the prod db and repeting it when scrolling
    image

  • Projects tabs with Vue error

  • townsquare seems without styles. not sure if that how suppose to be
    image

  • Is showed myself as an option to follow
    image

  • need a key :key= probably profile.id is a good one.

@thelostone-mc thelostone-mc requested a review from octavioamu May 5, 2020 15:44
@thelostone-mc thelostone-mc merged commit 7e84e42 into master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants