match strictly to prevent profiles starting with web3 from redirecting #6535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6535 +/- ##
=======================================
Coverage 27.26% 27.26%
=======================================
Files 287 287
Lines 26712 26712
Branches 3945 3945
=======================================
Hits 7284 7284
+ Misses 19161 19157 -4
- Partials 267 271 +4
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where a username starting with the prefix "web3" would get handled by the wrong view if trying to view their profile.
Refers/Fixes
reported on slack
Testing
tested locally