Skip to content

Conversation

@sebastiantf
Copy link
Contributor

@sebastiantf sebastiantf commented Apr 28, 2020

Description

Changes the selected option button color on Quests.

Refers/Fixes

Fixes #6517

Screenshots

Without any options selected:

questoptions1

With options selected and/or hovered:

0

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

blue

green

red

@sebastiantf sebastiantf changed the title change quest selected option button color Change Quest selected option button color to green for better UI Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #6522 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6522      +/-   ##
==========================================
+ Coverage   27.26%   27.29%   +0.02%     
==========================================
  Files         287      287              
  Lines       26712    26712              
  Branches     3945     3945              
==========================================
+ Hits         7284     7290       +6     
+ Misses      19161    19155       -6     
  Partials      267      267              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a70e3...51c837c. Read the comment docs.

@sebastiantf sebastiantf force-pushed the change-selected-button-color branch from b7c9e88 to f2d232e Compare April 29, 2020 19:57
@sebastiantf
Copy link
Contributor Author

sebastiantf commented Apr 29, 2020

@owocki Please let me know of any changes or suggestions.

To refer to the images/backgrounds, start from 0-33 and then blue, green, red in the end. (or maybe repost the image 🤷‍♂️)

@sebastiantf sebastiantf force-pushed the change-selected-button-color branch from f2d232e to b593f82 Compare April 29, 2020 20:11
@octavioamu octavioamu merged commit 06ed728 into gitcoinco:master Apr 29, 2020
@thelostone-mc
Copy link
Contributor

The screenshots <3
Thanks @sebastiantf ! Those really help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change button design of Quest selected options in such a way that it is distinguishable against any background.

3 participants