Skip to content

Conversation

@thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented Apr 20, 2020

Description

removes discord integration

Testing
  • bounty flow
  • hackathon bounty flow

@thelostone-mc thelostone-mc marked this pull request as ready for review April 20, 2020 15:07
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #6475 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6475      +/-   ##
==========================================
+ Coverage   27.18%   27.25%   +0.06%     
==========================================
  Files         289      289              
  Lines       26464    26383      -81     
  Branches     3923     3910      -13     
==========================================
- Hits         7194     7190       -4     
+ Misses      19003    18926      -77     
  Partials      267      267              
Impacted Files Coverage Δ
app/app/urls.py 86.44% <ø> (ø)
app/dashboard/context/hackathon.py 0.00% <ø> (ø)
app/dashboard/export.py 60.36% <ø> (ø)
app/dashboard/helpers.py 14.19% <ø> (+0.03%) ⬆️
app/dashboard/models.py 49.57% <ø> (+0.05%) ⬆️
app/dashboard/notifications.py 17.15% <ø> (+0.51%) ⬆️
app/dashboard/tasks.py 38.88% <ø> (+0.55%) ⬆️
app/dashboard/views.py 11.28% <ø> (+0.03%) ⬆️
app/marketing/views.py 12.01% <100.00%> (+0.40%) ⬆️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6b38df...95a9ba3. Read the comment docs.

from django.db import migrations


class Migration(migrations.Migration):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im ok with this but @danlipert told about fields removals the other day and kind of make sense, anyway guys I let to you decide on this removal or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got the data backed up!
And we are shutting down the discord server this week !

@thelostone-mc thelostone-mc merged commit 1af68c5 into gitcoinco:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants