Skip to content

Conversation

@androolloyd
Copy link
Contributor

@androolloyd androolloyd commented Apr 13, 2020

Description

Post Deploy Fixes/Tweaks

  • cleanup, post deploy fixes, and some layout fixes
  • registration button
  • add to channel bug fix
  • ensures the old onboard url will still work

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #6427 into master will decrease coverage by 0.00%.
The diff coverage is 5.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6427      +/-   ##
==========================================
- Coverage   27.20%   27.19%   -0.01%     
==========================================
  Files         290      290              
  Lines       26540    26546       +6     
  Branches     3930     3930              
==========================================
  Hits         7219     7219              
- Misses      19051    19061      +10     
+ Partials      270      266       -4     
Impacted Files Coverage Δ
app/app/urls.py 86.44% <ø> (ø)
app/chat/tasks.py 14.01% <0.00%> (-0.14%) ⬇️
app/dashboard/models.py 49.73% <0.00%> (ø)
app/dashboard/views.py 11.13% <0.00%> (-0.02%) ⬇️
app/economy/tx.py 0.00% <0.00%> (ø)
app/grants/management/commands/estimate_clr.py 0.00% <0.00%> (ø)
...nts/management/commands/ingest_givingblock_txns.py 0.00% <0.00%> (ø)
...nagement/commands/validate_grants_contributions.py 0.00% <0.00%> (ø)
app/grants/clr.py 13.10% <18.75%> (ø)
app/grants/models.py 48.59% <40.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baedc63...baedc63. Read the comment docs.

- register button pushes users to onboarding
- only prizes and projects are available to non registered users
- cleanup of stale code/review tweaks
…ate filter to prevent long running paragraphs
@androolloyd androolloyd changed the title fix for the hackathon banner background and text overrides Fixes for the Post Hackathon TownSquare Deploy - Needs Review Apr 14, 2020
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of this was fixed on production already probably need to cherry pick code from here to a new pr to avoid overwrites

@androolloyd androolloyd changed the base branch from stable to master April 15, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants