Skip to content

chore: merge es command #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2020
Merged

chore: merge es command #6414

merged 1 commit into from
Apr 15, 2020

Conversation

@thelostone-mc
Copy link
Contributor

@thelostone-mc thelostone-mc commented Apr 10, 2020

Description
  • removed extra mgmt command to index elastic search
  • added argument into sync_type to update_search_index
  • updated cron command and removedcreate_search_index # not needed
Test

Tested locally by running

docker-compose exec web python3 app/manage.py update_search_index create
docker-compose exec web python3 app/manage.py update_search_index update

@thelostone-mc thelostone-mc requested a review from owocki April 10, 2020 01:41
@codecov
Copy link

codecov bot commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #6414 into master will increase coverage by 0.02%.
The diff coverage is 15.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6414      +/-   ##
==========================================
+ Coverage   27.42%   27.45%   +0.02%     
==========================================
  Files         287      287              
  Lines       26167    26194      +27     
  Branches     3869     3873       +4     
==========================================
+ Hits         7177     7191      +14     
- Misses      18721    18738      +17     
+ Partials      269      265       -4
Impacted Files Coverage Δ
app/app/urls.py 86.44% <ø> (ø)
app/marketing/views.py 11.61% <0.00%> (ø)
app/townsquare/views.py 10.14% <0.00%> (-0.05%) ⬇️
app/dashboard/views.py 11.10% <6.25%> (-0.04%) ⬇️
app/search/views.py 30.00% <25.00%> (+1.87%) ⬆️
app/app/settings.py 81.42% <50.00%> (+0.05%) ⬆️
app/grants/views.py 15.96% <100.00%> (+0.48%) ⬆️
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
...eting/management/commands/assemble_leaderboards.py 40.48% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd31769...a027f99. Read the comment docs.

@thelostone-mc thelostone-mc force-pushed the master branch 2 times, most recently from 39b9c03 to a027f99 Compare April 13, 2020 12:32
@thelostone-mc thelostone-mc merged commit c636ddc into gitcoinco:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owocki owocki Awaiting requested review from owocki

2 more reviewers

@danlipert danlipert danlipert approved these changes

@octavioamu octavioamu octavioamu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thelostone-mc @danlipert @octavioamu