Skip to content

Conversation

@zoek1
Copy link
Contributor

@zoek1 zoek1 commented Apr 1, 2020

Description
  • Implement the headers and sidebar of the new hackathons design
  • Implement design for prizes list
  • Implement projects views
Refers/Fixes

No issue

Testing

Hackathon prizes

Image Pasted at 2020-3-30 01-00

Projects view

Image Pasted at 2020-3-31 01-52

Responsive View

image

{% endif %}
<small>{{ hackathon.start_date|date:"M j, Y" }} - {{ hackathon.end_date|date:"M j, Y" }}</small>
</div>
<a href="/{{hackathon.town_square_link}}" class="btn btn-gc-blue register col-xs-12 mt-4 mb-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what this "register" button do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects to the hackathon onboarding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #6347 into master will increase coverage by 0.00%.
The diff coverage is 11.11%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6347   +/-   ##
=======================================
  Coverage   27.63%   27.64%           
=======================================
  Files         281      281           
  Lines       26037    26054   +17     
  Branches     3837     3841    +4     
=======================================
+ Hits         7195     7202    +7     
- Misses      18578    18588   +10     
  Partials      264      264           
Impacted Files Coverage Δ
app/townsquare/views.py 10.18% <11.11%> (-0.19%) ⬇️
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be64e9e...f9086b9. Read the comment docs.

@octavioamu
Copy link
Contributor

How projects explorer queries and paginations are being handled here? since use to work with url params

@octavioamu octavioamu merged commit 97840d6 into gitcoinco:master Apr 1, 2020
@octavioamu
Copy link
Contributor

code merged already in #6359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants