Skip to content

Conversation

@octavioamu
Copy link
Contributor

Description

Add optin screen to orgs
remove scopes from normal signup
start the sync on scopes oauth

Refers/Fixes

Fix: #5408

Testing

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #5495 into master will increase coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5495      +/-   ##
=========================================
+ Coverage   29.18%   29.2%   +0.01%     
=========================================
  Files         244     244              
  Lines       20962   20978      +16     
  Branches     3027    3029       +2     
=========================================
+ Hits         6118    6126       +8     
- Misses      14599   14604       +5     
- Partials      245     248       +3
Impacted Files Coverage Δ
...p/dashboard/management/commands/sync_orgs_repos.py 0% <ø> (ø)
app/dashboard/utils.py 42.73% <0%> (+0.26%) ⬆️
app/marketing/views.py 11.35% <0%> (-0.12%) ⬇️
app/app/settings.py 79.92% <100%> (+0.21%) ⬆️
app/app/utils.py 22.07% <40%> (+0.62%) ⬆️
app/dashboard/views.py 12.75% <50%> (+0.03%) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e1ef4...24e689b. Read the comment docs.

@danlipert
Copy link
Contributor

@octavioamu is this still a WIP? looks pretty good, but theres lots of print debugs left in so I'm not sure

@octavioamu
Copy link
Contributor Author

@danlipert prints removed!!

@thelostone-mc thelostone-mc merged commit dd5dd87 into master Nov 20, 2019
@thelostone-mc thelostone-mc deleted the optin-org branch June 27, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants