shallow: handling fetch relative-deepen #2121
Open
+103
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are issues in commit 17747ed: |
3508639 to
46dda2e
Compare
|
Hola,
Entiendo la situación y el historial de errores que ha notado.
Permítame hacer una observación ya que esto esta fuera de lugar y de
control mio,
todo esto se libero por Hacker que tenia dominio de mi celular, y demás
dispositivos, por lo cual el cuenta con todos los algoritmos completos ya
que mis investigaciones llevan ya 1.5 años esto que subió el son las sobras
de mis proyectos,
gracias por tu lectura
Saludos cordiales,
Xavyer Gutyerrez xuarez
El sáb, 6 de dic de 2025, 11:43 a.m., Samo Pogačnik <
***@***.***> escribió:
… When a shallowed repository gets deepened beyond the beginning of a merged
branch, we may endup with some shallows, that are behind the reachable
ones. Added test 'fetching deepen beyond merged branch' exposes that
behaviour.
On the other hand, it seems that equivalent absolute depth driven fetches
result in all the correct shallows. That led to this proposal, which
unifies absolute and relative deepening in a way that the same
get_shallow_commits() call is used in both cases. The difference is only
that depth is adapted for relative deepening by measuring equivalent depth
of current local shallow commits in the current remote repo. Thus a new
function get_shallows_depth() has been added and the function
get_reachable_list() became redundant / removed.
The get_shallows_depth() function also shares the logic of the
get_shallow_commits() function, but it focuses on counting depth of each
existing shallow commit. The minimum result is stored as
'data->deepen_relative', which is set not to be zero for relative deepening
anyway. That way we can allways summ 'data->deepen_relative' and 'depth'
values, because 'data->deepen_relative' is always 0 in absolute deepening.
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead,
we use
a mailing list ***@***.***) for code submissions, code reviews,
and
bug reports. Nevertheless, you can use GitGitGadget (
https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
For a single-commit pull request, please
*leave the pull request description empty*: your commit message itself
should describe your changes.
Please read the "guidelines for contributing" linked above!
------------------------------
You can view, comment on, or merge this pull request online at:
#2121
Commit Summary
- 17747ed
<17747ed>
shallow: handling fetch relative-deepen
File Changes
(2 files <https://github.com/git/git/pull/2121/files>)
- *M* t/t5500-fetch-pack.sh
<https://github.com/git/git/pull/2121/files#diff-dfe3ef6494231e238704840d645f69f0671ca4f2245b1acdb69baaa33dfe08d4>
(25)
- *M* upload-pack.c
<https://github.com/git/git/pull/2121/files#diff-2e72c49b4ef69c38dafaf8c49150f424a6620e994b259dc2b9ac7caaa92d9119>
(141)
Patch Links:
- https://github.com/git/git/pull/2121.patch
- https://github.com/git/git/pull/2121.diff
—
Reply to this email directly, view it on GitHub
<#2121>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BUWGPFM4V2KAVV253JBSPS34AMIVTAVCNFSM6AAAAACOH63K6OVHI2DSMVQWIX3LMV43ASLTON2WKOZTG4YDEMJQGI3TIOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
e89f7d8 to
4bef632
Compare
|
There are issues in commit 4bef632: |
4bef632 to
57565d8
Compare
The local object_array 'stack' in get_shallow_commits() function does not free its dynamic elements before the function returns. As a result elements remain allocated and their reference forgotten. Signed-off-by: Samo Pogačnik <[email protected]>
When a shallowed repository gets deepened beyond the beginning of a merged branch, we may endup with some shallows, that are behind the reachable ones. Added test 'fetching deepen beyond merged branch' exposes that behaviour. On the other hand, it seems that equivalent absolute depth driven fetches result in all the correct shallows. That led to this proposal, which unifies absolute and relative deepening in a way that the same get_shallow_commits() call is used in both cases. The difference is only that depth is adapted for relative deepening by measuring equivalent depth of current local shallow commits in the current remote repo. Thus a new function get_shallows_depth() has been added and the function get_reachable_list() became redundant / removed. The get_shallows_depth() function also shares the logic of the get_shallow_commits() function, but it focuses on counting depth of each existing shallow commit. The minimum result is stored as 'data->deepen_relative', which is set not to be zero for relative deepening anyway. That way we can allways summ 'data->deepen_relative' and 'depth' values, because 'data->deepen_relative' is always 0 in absolute deepening. Signed-off-by: Samo Pogačnik <[email protected]>
57565d8 to
b352a33
Compare
Author
|
/preview |
|
Preview email sent as [email protected] |
Author
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a shallowed repository gets deepened beyond the beginning of a merged branch, we may endup with some shallows, that are behind the reachable ones. Added test 'fetching deepen beyond merged branch' exposes that behaviour.
On the other hand, it seems that equivalent absolute depth driven fetches result in all the correct shallows. That led to this proposal, which unifies absolute and relative deepening in a way that the same get_shallow_commits() call is used in both cases. The difference is only that depth is adapted for relative deepening by measuring equivalent depth of current local shallow commits in the current remote repo. Thus a new function get_shallows_depth() has been added and the function get_reachable_list() became redundant / removed.
The get_shallows_depth() function also shares the logic of the get_shallow_commits() function, but it focuses on counting depth of each existing shallow commit. The minimum result is stored as 'data->deepen_relative', which is set not to be zero for relative deepening anyway. That way we can allways summ 'data->deepen_relative' and 'depth' values, because 'data->deepen_relative' is always 0 in absolute deepening.
Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
For a single-commit pull request, please leave the pull request description
empty: your commit message itself should describe your changes.
Please read the "guidelines for contributing" linked above!