Welcome to GitGitGadget

Hi @RuanXinyu, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

• Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
• Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <[email protected]>, Ill Takalook <[email protected]>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

/allow

Error: User sunchao99 is not yet permitted to use GitGitGadget

/allow

User RuanXinyu is now allowed to use GitGitGadget.

/preview

Preview email sent as [email protected]

/submit

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-2082/RuanXinyu/fix-refs-trace-migrate-error-v1

To fetch this version to local tag pr-git-2082/RuanXinyu/fix-refs-trace-migrate-error-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-2082/RuanXinyu/fix-refs-trace-migrate-error-v1

On the Git mailing list, Patrick Steinhardt wrote (reply to this):

On Fri, Oct 24, 2025 at 08:38:14AM +0000, RuanXinyu via GitGitGadget wrote:
> From: RuanXinyu <[email protected]>
> 
> The debug ref backend (refs_be_debug) was missing the remove_on_disk
> function pointer, which caused a segmentation fault when running
> 'GIT_TRACE_REFS=1 git refs migrate --ref-format=reftable' commands.

Heh, funny, just as I said nobody uses this infra you show up :) Good
way to prove me wrong, thanks!

> Signed-off-by: Xinyu Ruan <[email protected]>

Tiny nit: typically, the author and DCO should match. But the autor is
"RuanXinyu" whereas the DCO says "Xinyu Ruan". I don't really think that
this is something that warrants a new version, but I wanted to point
this out anyway so that you can fix this going forward.

> diff --git a/refs/debug.c b/refs/debug.c
> index da300efaf3..dd49080836 100644
> --- a/refs/debug.c
> +++ b/refs/debug.c
> @@ -48,6 +48,14 @@ static int debug_create_on_disk(struct ref_store *refs, int flags, struct strbuf
>  	return res;
>  }
>  
> +static int debug_remove_on_disk(struct ref_store *refs, struct strbuf *err)
> +{
> +	struct debug_ref_store *drefs = (struct debug_ref_store *)refs;
> +	int res = drefs->refs->be->remove_on_disk(drefs->refs, err);
> +	trace_printf_key(&trace_refs, "remove_on_disk: %d\n", res);
> +	return res;
> +}
> +
>  static int debug_transaction_prepare(struct ref_store *refs,
>  				     struct ref_transaction *transaction,
>  				     struct strbuf *err)
> @@ -432,6 +440,7 @@ struct ref_storage_be refs_be_debug = {
>  	.init = NULL,
>  	.release = debug_release,
>  	.create_on_disk = debug_create_on_disk,
> +	.remove_on_disk = debug_remove_on_disk,
>  
>  	/*
>  	 * None of these should be NULL. If the "files" backend (in

Yup, the implementation looks obviously correct to me. Thanks for fixing
this bug!

Patrick

User Patrick Steinhardt <[email protected]> has been added to the cc: list.

On the Git mailing list, Junio C Hamano wrote (reply to this):

Patrick Steinhardt <[email protected]> writes:

>> Signed-off-by: Xinyu Ruan <[email protected]>
>
> Tiny nit: typically, the author and DCO should match. But the autor is
> "RuanXinyu" whereas the DCO says "Xinyu Ruan". I don't really think that
> this is something that warrants a new version, but I wanted to point
> this out anyway so that you can fix this going forward.

It may not warrant a new version in the sense that I could tweak
while queuing, but I need to be told which between the two is the
name to be used before doing so.

I can make a guess and use the latter but it would cause me yet
another piece of extra work if I guessed incorrectly, so...

On the Git mailing list, 阮新宇 wrote (reply to this):

On Fri, Oct 24, 2025 at 11:13 PM Junio C Hamano <[email protected]> wrote:
>
> Patrick Steinhardt <[email protected]> writes:
>
> >> Signed-off-by: Xinyu Ruan <[email protected]>
> >
> > Tiny nit: typically, the author and DCO should match. But the autor is
> > "RuanXinyu" whereas the DCO says "Xinyu Ruan". I don't really think that
> > this is something that warrants a new version, but I wanted to point
> > this out anyway so that you can fix this going forward.
>
> It may not warrant a new version in the sense that I could tweak
> while queuing, but I need to be told which between the two is the
> name to be used before doing so.
>
> I can make a guess and use the latter but it would cause me yet
> another piece of extra work if I guessed incorrectly, so...

Please use "Xinyu Ruan" for both author and Signed-off-by.
Sorry for the confusion, and thanks for fixing it while queuing.

User 阮新宇 <[email protected]> has been added to the cc: list.

This branch is now known as xr/ref-debug-remove-on-disk.

This patch series was integrated into seen via 4191d6d.