Skip to content

Conversation

EndlessParadox1
Copy link
Contributor

replace the self-defined 'min' to official one and solve the func 'max' name conflict in tree.go.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (3dc1cd6) to head (d1a415b).
Report is 60 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3975      +/-   ##
==========================================
- Coverage   99.21%   99.05%   -0.17%     
==========================================
  Files          42       44       +2     
  Lines        3182     2747     -435     
==========================================
- Hits         3157     2721     -436     
+ Misses         17       15       -2     
- Partials        8       11       +3     
Flag Coverage Δ
?
-tags "sonic avx" 99.04% <100.00%> (?)
-tags go_json 99.04% <100.00%> (?)
-tags nomsgpack 99.03% <100.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 99.05% <100.00%> (-0.17%) ⬇️
go-1.22 99.05% <100.00%> (?)
macos-latest 99.03% <100.00%> (-0.18%) ⬇️
ubuntu-latest 99.05% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EndlessParadox1 EndlessParadox1 changed the title solve a little bug replace the self-defined 'min' to official one May 21, 2024
@appleboy appleboy changed the title replace the self-defined 'min' to official one chore(tree): replace the self-defined 'min' to official one May 24, 2024
@appleboy appleboy added this to the v1.11 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants