Skip to content

fix(binding): binding error while not upload file (#3819) #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix(binding): binding error while not upload file (#3819) #3820

merged 2 commits into from
Feb 5, 2024

Conversation

clearcodecn
Copy link
Contributor

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

fix: #3819

@clearcodecn
Copy link
Contributor Author

Is someone maintaining this warehouse? Why hasn't anyone replied to any issues or PR?

@appleboy appleboy added the type/bug Found something you weren't expecting? Report it here! label Feb 1, 2024
@appleboy appleboy added this to the v1.10 milestone Feb 1, 2024
@appleboy
Copy link
Member

appleboy commented Feb 1, 2024

I will take it before #3834 merge

@appleboy
Copy link
Member

appleboy commented Feb 1, 2024

@clearcodecn Please help to rebase the master branch

@clearcodecn
Copy link
Contributor Author

@appleboy done, thank you.

@appleboy appleboy changed the title fix: binding error while not upload file (#3819) fix(binding): binding error while not upload file (#3819) Feb 5, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f598a3) 99.21% compared to head (97d7376) 99.21%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3820   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files          42       42           
  Lines        3180     3182    +2     
=======================================
+ Hits         3155     3157    +2     
  Misses         17       17           
  Partials        8        8
Flag Coverage Δ
99.21% <100.00%> (+<0.01%) ⬆️
go-1.18 99.12% <100.00%> (+<0.01%) ⬆️
go-1.19 99.21% <100.00%> (+<0.01%) ⬆️
go-1.20 99.21% <100.00%> (+<0.01%) ⬆️
go-1.21 99.21% <100.00%> (+<0.01%) ⬆️
macos-latest 99.21% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 99.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit 3dc1cd6 into gin-gonic:master Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy approved these changes

Assignees

No one assigned

Labels

type/bug Found something you weren't expecting? Report it here!

Projects

None yet

Milestone

v1.10

Development

Successfully merging this pull request may close these issues.

Binding a non mandatory file parameter will directly result in an error message

2 participants

@clearcodecn @appleboy