Skip to content

fix(context): panic on NegotiateFormat - index out of range #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix(context): panic on NegotiateFormat - index out of range #3397

merged 1 commit into from
Jan 16, 2023

Conversation

adrianiacobghiula
Copy link
Contributor

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@appleboy appleboy added the type/bug Found something you weren't expecting? Report it here! label Nov 17, 2022
@appleboy appleboy added this to the v1.9 milestone Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #3397 (ff9e36d) into master (a0acf1d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3397   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          42       42           
  Lines        3137     3137           
=======================================
  Hits         3083     3083           
  Misses         40       40           
  Partials       14       14
Flag Coverage Δ
98.27% <100.00%> (ø)
go-1.16 ?
go-1.17 98.18% <100.00%> (ø)
go-1.18 98.18% <100.00%> (ø)
go-1.19 98.27% <100.00%> (ø)
macos-latest 98.27% <100.00%> (+0.09%) ⬆️
ubuntu-latest 98.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
context.go 97.96% <100.00%> (ø)
recovery.go 98.07% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appleboy appleboy changed the title panic on NegotiateFormat - index out of range fix(context): panic on NegotiateFormat - index out of range Jan 16, 2023
@appleboy appleboy merged commit 7cb151b into gin-gonic:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

Assignees

No one assigned

Labels

type/bug Found something you weren't expecting? Report it here!

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianiacobghiula @appleboy @thinkerou