Skip to content

return err instead of panic in Render #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

return err instead of panic in Render #3039

wants to merge 1 commit into from

Conversation

@Tevic
Copy link
Contributor

@Tevic Tevic commented Jan 26, 2022 •
edited
Loading

This PR resolve issues like:
#2150

Change-Id: I3ce1afb327fea7a92a21e27649f7af87e286bf26

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@codecov
Copy link

codecov bot commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #3039 (7fb2501) into master (580e7da) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 7fb2501 differs from pull request most recent head 4cfab1b. Consider uploading reports for the commit 4cfab1b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
- Coverage   98.60%   98.60%   -0.01%     
==========================================
  Files          41       41              
  Lines        3084     3082       -2     
==========================================
- Hits         3041     3039       -2     
  Misses         30       30              
  Partials       13       13
Flag Coverage Δ
go-1.13 ∅ <ø> (∅)
go-1.14 ∅ <ø> (∅)
go-1.15 ∅ <ø> (∅)
go-1.16 98.60% <100.00%> (-0.01%) ⬇️
go-1.17 98.50% <100.00%> (-0.01%) ⬇️
macos-latest 98.60% <100.00%> (-0.01%) ⬇️
nomsgpack 98.58% <100.00%> (-0.01%) ⬇️
ubuntu-latest 98.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
render/json.go 82.75% <100.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580e7da...4cfab1b. Read the comment docs.

@Tevic Tevic changed the title return err instead of panic in JSON Render return err instead of panic in Render Jan 26, 2022
@Tevic Tevic closed this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Tevic