Skip to content

add support arrays on mapping #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2019
Merged

add support arrays on mapping #1797

merged 5 commits into from
Mar 14, 2019

Conversation

@vkd
Copy link
Contributor

@vkd vkd commented Mar 5, 2019 

var s struct {
	Nums [2]int `form:"nums"`
}
req := formPostRequest("", "nums=3&nums=8")
Form.Bind(req, &s)

@codecov
Copy link

codecov bot commented Mar 5, 2019 •
edited
Loading

Codecov Report

Merging #1797 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1797      +/-   ##
==========================================
+ Coverage   98.62%   98.63%   +<.01%     
==========================================
  Files          41       41              
  Lines        2113     2124      +11     
==========================================
+ Hits         2084     2095      +11     
  Misses         18       18              
  Partials       11       11
Impacted Files Coverage Δ
binding/form_mapping.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab0749...35314e5. Read the comment docs.

@vkd vkd force-pushed the mapping_array branch from 6639fd9 to 0450799 Compare March 5, 2019 17:41
thinkerou
thinkerou reviewed Mar 7, 2019
View reviewed changes
@thinkerou thinkerou requested review from appleboy and thinkerou March 7, 2019 06:47
@thinkerou thinkerou added this to the 1.4 milestone Mar 7, 2019
@thinkerou thinkerou merged commit 483f828 into gin-gonic:master Mar 14, 2019
@vkd vkd deleted the mapping_array branch March 26, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy Awaiting requested review from appleboy

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

1.4

Development

Successfully merging this pull request may close these issues.

2 participants

@vkd @thinkerou