Router: Route StaticFS() not found to Router's NoRoute() #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1663 +/- ##
==========================================
+ Coverage 99.39% 99.39% +<.01%
==========================================
Files 41 41
Lines 1990 1993 +3
==========================================
+ Hits 1978 1981 +3
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
thinkerou
reviewed
Nov 26, 2018
thinkerou
approved these changes
Nov 26, 2018
Contributor
Author
|
Made it automergeable now. Thanks for reviewing :) |
appleboy
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1220