Change HTML link tags to use HTML5 syntax. #1621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `<link>` element is an empty element, it contains attributes only. In HTML5 the `<link>` tag has no end tag. In XHTML the `<link>` tag must be properly closed.
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 39 39
Lines 1931 1931
=======================================
Hits 1917 1917
Misses 10 10
Partials 4 4Continue to review full report at Codecov.
|
thinkerou
approved these changes
Nov 1, 2018
justinfx
pushed a commit
to justinfx/gin
that referenced
this pull request
Nov 3, 2018
The `<link>` element is an empty element, it contains attributes only. In HTML5 the `<link>` tag has no end tag. In XHTML the `<link>` tag must be properly closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<link>element is an empty element, it contains attributes only. In HTML5 the<link>tag has no end tag. In XHTML the<link>tag must be properly closed.https://www.w3schools.com/tags/tag_link.asp