Yaml binding #1618
Merged
Yaml binding #1618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 99.27% 99.28% +<.01%
==========================================
Files 39 40 +1
Lines 1931 1948 +17
==========================================
+ Hits 1917 1934 +17
Misses 10 10
Partials 4 4
Continue to review full report at Codecov.
|
Contributor
Author
|
I'll take a look at improving the test coverage in the next day or so. |
thinkerou
reviewed
Nov 3, 2018
thinkerou
reviewed
Nov 3, 2018
Member
|
@appleboy please update review comment and then LGTM, thanks! |
thinkerou
approved these changes
Nov 5, 2018
appleboy
requested changes
Nov 5, 2018
appleboy
approved these changes
Nov 5, 2018
Member
|
@thinkerou Sorry. The external package has already in go.mod. |
Member
|
@appleboy yes, no sweat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds binding support for YAML.
Sidenote:
testBodyBindingusesJSON.Bindinstead of theBindinginstance passed as a parameter when testing thebadBody. Is this intended?