fix: fmt output log to os.Stderr #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 39 39
Lines 1929 1929
=======================================
Hits 1911 1911
Misses 14 14
Partials 4 4
Continue to review full report at Codecov.
|
Member
|
have
|
giulianobr
reviewed
Sep 26, 2018
giulianobr
left a comment
There was a problem hiding this comment.
With this change, App Engine local development server works fine.
thinkerou
approved these changes
Sep 26, 2018
justinfx
pushed a commit
to justinfx/gin
that referenced
this pull request
Nov 3, 2018
fix gin-gonic#1560 changes are breaking in App Engine. cc @giulianobr @philippgille
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Dec 4, 2020
The output of GIN debug was redirected to stderr instead of stdout
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Dec 14, 2020
The output of GIN debug was redirected to stderr instead of stdout
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Dec 17, 2020
* change approach: redirect stderr to file instead using defer * update gin dependency because of gin-gonic/gin#1571 * set default logger to stdout. (stderr is currently redirected to file) * save crash-report to newly created `logs/` folder * add enable/disable crash-report generation (default off) * add entry in trayicon's menu to remove crash-reports (if there are any) * CI polishing, add win64, update macOS min version (#578)
umbynos
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Dec 18, 2020
* change approach: redirect stderr to file instead using defer * update gin dependency because of gin-gonic/gin#1571 * set default logger to stdout. (stderr is currently redirected to file) * save crash-report to newly created `logs/` folder * add enable/disable crash-report generation (default off) * add entry in trayicon's menu to remove crash-reports (if there are any) * CI polishing, add win64, update macOS min version (#578)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1560 changes are breaking in App Engine.
cc @giulianobr @philippgille