Skip to content

fix compile error for -tags=jsoniter #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2018
Merged

fix compile error for -tags=jsoniter #1500

merged 1 commit into from
Aug 20, 2018

Conversation

@junfengye
Copy link
Contributor

@junfengye junfengye commented Aug 20, 2018

add newencoder to fix compile error for -tags=jsoniter

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integrations systems such as TravisCI.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@junfengye
Update jsoniter.go
58d197d 
add newencoder to fix compile error for -tags=jsoniter
@junfengye junfengye changed the title Update jsoniter.go fix compile error for -tags=jsoniter Aug 20, 2018
@codecov
Copy link

codecov bot commented Aug 20, 2018 •
edited
Loading

Codecov Report

Merging #1500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          39       39           
  Lines        1914     1914           
=======================================
  Hits         1898     1898           
  Misses         13       13           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6110f9...58d197d. Read the comment docs.

@thinkerou
Copy link
Member

thinkerou commented Aug 20, 2018

ref #694 LGTM

@thinkerou thinkerou added enhancement type/bug Found something you weren't expecting? Report it here! and removed enhancement labels Aug 20, 2018
@thinkerou thinkerou merged commit 0ebd42d into gin-gonic:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy Awaiting requested review from appleboy

Assignees

No one assigned

Labels

type/bug Found something you weren't expecting? Report it here!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@junfengye @thinkerou